Skip to content

refactor: remove dead guest stackoverflow reporting code #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsturtevant merged 1 commit into from
Feb 20, 2026
Merged

refactor: remove dead guest stackoverflow reporting code #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/hyperlight_host/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,10 +229,6 @@ pub enum HyperlightError {
#[error("Snapshot Size Mismatch: Memory Size {0:?} Snapshot Size {1:?}")]
SnapshotSizeMismatch(usize, usize),

/// Stack overflow detected in guest
#[error("Stack overflow detected")]
StackOverflow(),

/// Tried to restore snapshot to a sandbox that is not the same as the one the snapshot was taken from
#[error("Snapshot was taken from a different sandbox")]
SnapshotSandboxMismatch,
Expand Down Expand Up @@ -323,7 +319,6 @@ impl HyperlightError {
| HyperlightError::ExecutionCanceledByHost()
| HyperlightError::PoisonedSandbox
| HyperlightError::ExecutionAccessViolation(_)
| HyperlightError::StackOverflow()
| HyperlightError::MemoryAccessViolation(_, _, _)
| HyperlightError::SnapshotSizeMismatch(_, _)
| HyperlightError::MemoryRegionSizeMismatch(_, _, _)
Expand Down
4 changes: 0 additions & 4 deletions src/hyperlight_host/tests/integration_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,10 +592,6 @@ fn guest_panic_no_alloc() {
)
.unwrap_err();

if let HyperlightError::StackOverflow() = res {
panic!("panic on OOM caused stack overflow, this implies allocation in panic handler");
}

assert!(
matches!(
&res,
Expand Down
Loading