Merged
Conversation
541f5ed to
3066d57
Compare
ludfjig
previously approved these changes
Jan 22, 2026
Contributor
ludfjig
left a comment
There was a problem hiding this comment.
LGTM, and big fan of the cleanup!
dblnz
reviewed
Jan 22, 2026
andreiltd
reviewed
Jan 23, 2026
andreiltd
reviewed
Jan 23, 2026
andreiltd
reviewed
Jan 23, 2026
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This has to materialise a number of .cargo/config.toml into the tree in order to point Cargo at the Nix-vendored deps. Ideally, the cargo wrapper script would just pass some config information, but unfortunately, due to rust-lang/cargo#11031, external subcommands do not respect --config and will only pick up configuration that's actually in .cargo/config.toml files in the tree. In order to reduce the risk of these getting improperly committed to the repository, the script also adds them to .git/info/exclude whenever it creates them. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Previously, it could not be used after the guests were built, due to some extra generated files. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
3c59be8 to
289b0f8
Compare
Member
Author
|
@andreiltd @ludfjig Thanks for the reviews---I believe I added fixup! commits for most of your comments? There was also quite some churn in the base commit during rebasing due to the error PR merging, but I don't think anything semantically changed. |
This changes the representation of a memory region on Windows to include a file mapping from which it is derived, allowing the WHP code to dynamically map any files necessary into the surrogate. This removes the restriction that all mappings into a hyperlight VM on Windows must come from a single file-backed host mapping. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
This adds a second region of guest physical memory, which is intended to become the only mutable region of memory, but which is currently unused. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
289b0f8 to
7ca0a78
Compare
Member
Author
|
I have squashed the fixup!s in, in preparation for fast-forward merging this. |
dblnz
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the new scratch region, which will eventually become where everything writable is, but is currently not used.
A prerequisite of this is to improve whp support for dynamically mapping file handles into the surrogate process. The same infrastructure could be used to expose (some parts of) the host mapping API on Windows.