Remove duplicate GVA-to-GPA translation in sw breakpoint functions

[IrvingMg]

Fix double GVA-to-GPA translation in add_sw_breakpoint and remove_sw_breakpoint. These functions were translating addresses before passing them to read_addrs/write_addrs, which translate internally.

Fixes #1046

[jsturtevant]

Thanks @IrvingMg! this look good on a quick glance. Might have @dblnz take a look. Given holidays might be slow.

Could you sign your commit? https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

[IrvingMg]

Could you sign your commit? https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

Oops, missed that! It’s signed now. Thanks!

[dblnz]

LGTM!
Thanks for your contribution @IrvingMg ! 😺

[ludfjig]

Thanks for this, it looks good to me. However I wonder if we can remove these? I'm not sure whether they are related to this or not, but they look suspicious...

https://github.com/IrvingMg/hyperlight/blob/0397689c166da4af27a6b6d102c672107df40c4f/src/hyperlight_host/src/hypervisor/hyperlight_vm.rs#L650-L653

https://github.com/IrvingMg/hyperlight/blob/0397689c166da4af27a6b6d102c672107df40c4f/src/hyperlight_host/src/hypervisor/hyperlight_vm.rs#L699-L702

Perhaps @dblnz knows?

[dblnz]

Thanks for this, it looks good to me. However I wonder if we can remove these? I'm not sure whether they are related to this or not, but they look suspicious...

https://github.com/IrvingMg/hyperlight/blob/0397689c166da4af27a6b6d102c672107df40c4f/src/hyperlight_host/src/hypervisor/hyperlight_vm.rs#L650-L653

https://github.com/IrvingMg/hyperlight/blob/0397689c166da4af27a6b6d102c672107df40c4f/src/hyperlight_host/src/hypervisor/hyperlight_vm.rs#L699-L702

Perhaps @dblnz knows?

I don't think those can be eliminated. We still need to report an error when the debugger client requests operating on an address that is not valid for the guest.
This PR eliminates the double translation from SW breakpoints, because the virtual address is still translated by the read_addrs and write_addrs calls.