Fix all clippy warnings

[gtsiam]

Fixes all clippy warnings.

Split from #649.

[LucioFranco]

LGTM but left some comments, we should back out some of the clippy changes and add them to a global allow.

[gtsiam]

Also while I'm at it: Would you like me to add a style check to the ci so there's no need to do this kind of large pr again?

[LucioFranco]

Also while I'm at it: Would you like me to add a style check to the ci so there's no need to do this kind of large pr again?

You mean run clippy in ci? I personally don't like it since it adds a lot of noise.

[gtsiam]

You mean run clippy in ci? I personally don't like it since it adds a lot of noise.

Yes. Though I really wouldn't call clippy warnings "noise". With the exception of the manual_range_contains lint, most of the changes in this pr should never have needed to be done in mass. Catching them earlier would be much easier for all involved.

But I'm not gonna push for it. You're the maintainer. If you don't want it, you don't want it and that's the end of that.

[gtsiam]

Ok, everything should be resolved now

[LucioFranco]

LGTM thanks!