Skip to content

Stack Trace and Breadcrumbs table polish #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svc-shorpo merged 3 commits into from
Nov 21, 2023
Merged

Stack Trace and Breadcrumbs table polish #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a59492f
Stack Trace and Breadcrumbs table polish
svc-shorpo Nov 18, 2023
ae59000
Address comments – JSON.parse
svc-shorpo Nov 21, 2023
ec9bf7b
Merge branch 'main' into sentry
svc-shorpo Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tame-birds-thank.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperdx/app': minor
---

feat: Log Side Panel styling
1 change: 1 addition & 0 deletions packages/app/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export default function MyApp({ Component, pageProps }: AppProps) {
name="viewport"
content="width=device-width, initial-scale=0.75"
/>
<meta name="theme-color" content="#25292e"></meta>
</Head>

<SSRProvider>
Expand Down
7 changes: 2 additions & 5 deletions packages/app/src/HDXTableChart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import {
ColumnDef,
flexRender,
getCoreRowModel,
Row as TableRow,
useReactTable,
} from '@tanstack/react-table';
import { useVirtualizer } from '@tanstack/react-virtual';
import { useState, useCallback, useRef, useEffect, useMemo, memo } from 'react';
import { useCallback, useRef, memo } from 'react';
import cx from 'classnames';
import { UNDEFINED_WIDTH } from './tableUtils';

import api from './api';
import { AggFn } from './ChartUtils';
Expand All @@ -19,9 +19,6 @@ const Table = ({
data: any[];
valueColumnName: string;
}) => {
// https://github.com/TanStack/table/discussions/3192#discussioncomment-3873093
const UNDEFINED_WIDTH = 99999;

//we need a reference to the scrolling element for logic down below
const tableContainerRef = useRef<HTMLDivElement>(null);

Expand Down
Loading