Skip to content

Print details when package installation fails #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaaldjorMike merged 1 commit into from
Feb 13, 2025
Merged

Print details when package installation fails #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/api/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,12 +184,12 @@ func detailedInstallationError(response *http.Response) error {

body, err := io.ReadAll(response.Body) // response body is []byte
if err != nil {
return fmt.Errorf("the package could not be installed")
return fmt.Errorf("the package could not be installed, err=%q", err)
}

var result InstallationErrors
if err := json.Unmarshal(body, &result); err != nil {
return fmt.Errorf("the package could not be installed and the reason returned could not be parsed")
return fmt.Errorf("the package could not be installed and the reason returned could not be parsed, err=%q response=%q", err, body)
}

allErrors := append(result.ParseErrors, result.InstallationErrors...)
Expand Down