MX Contract Integration

[vladNed]

Description

The goal of this PR is to implement all the human protocol sol contract in rust with the official mx-sdk-rs package

Summary of changes

All the code that represents the contract code can be found in any contract src directory. The meta and wasm crates are separate crates that contain the framework for the mx-sdk-rs .

Implemented the following contracts:

• Escrow
• EscrowFactory
• KVStore
• RewardsPool
• Reputation
• Staking

I also implemented some of the mock contracts for proxy calls only used in testing purposes.

Possible bugs

I don't know how solidity works properly with upgrading contracts, but in most of the MX contracts upgrading some of the contract require re-sending the init parameters.

Some of the contracts, for instance the RewardsPool require the reward token to be set each time the contract is upgraded. I left it as it is in the solidity contract but I suggest to set it only if its empty and use a separate endpoint to reset the rewards token to another token if its required on upgrade. This will also give the possibility of paying out first the existing token amount.

Also in the RewardsPool contract, I observed that rewards records can be added with a 0 amount after the fees were deducted. I left it as it is on the original sol contract but I suggest that the records are added only if the amount after fees is greater than 0.

How test the changes

Testing the contracts was added to the README file but you can always run cargo test into the mx directory to run all contracts tests. Or on each contract run the tests from the test_*.rs files.

Related issues

Become the official HMT Elrond maintainer

Resolves #138

Operational checklist

• All new functionality is covered by tests
• Any related documentation has been changed or added

[CLAassistant]

All committers have signed the CLA.

[vercel]

@vladNed is attempting to deploy a commit to the HUMAN Protocol Team on Vercel.

A member of the Team first needs to authorize it.

[portuu3]

I don't know how solidity works properly with upgrading contracts, but in most of the MX contracts upgrading some of the contract require re-sending the init parameters.
in solidity storage keeps being the same when the contract is upgraded, so you don't really need to init again

[portuu3]

Some of the contracts, for instance the RewardsPool require the reward token to be set each time the contract is upgraded. I left it as it is in the solidity contract but I suggest to set it only if its empty and use a separate endpoint to reset the rewards token to another token if its required on upgrade. This will also give the possibility of paying out first the existing token amount.

Let's do this

[psorinionut]

I left a few suggestions & recommendations regarding mostly the code structure/architecture, and tried not to intervene as much in the code from the business logic perspective. Bottom line is that you should always try to optimise the code to go through as few lines of code as possible, and also try to reduce the storage readings to a minimum. This last part is very important, as it directly impacts the performance of the contract and this could make a difference as more users will begin to use it.

Also, I recommend you to upgrade to the latest framework (I see that now you are using version 0.39.2).

[portuu3]

fix comment 1% and you can remove bulk_paid from escrow contract

[portuu3]

@vladNed can you please add a gitflow action to run tests?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
exchange-oracle	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 16, 2023 at 11:02AM (UTC)