Skip to content

Token claims and vesting benchmarks#446

Merged
dmitrylavrenov merged 23 commits into
masterfrom
claims-integration-benchmark-run-blocks
Sep 2, 2022
Merged

Token claims and vesting benchmarks#446
dmitrylavrenov merged 23 commits into
masterfrom
claims-integration-benchmark-run-blocks

Conversation

@dmitrylavrenov
Copy link
Copy Markdown
Contributor

@dmitrylavrenov dmitrylavrenov commented Aug 25, 2022 •
edited
Loading

Closes #447

@dmitrylavrenov dmitrylavrenov changed the base branch from master to claims-integration August 25, 2022 12:27
MOZGIII
MOZGIII reviewed Aug 25, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Aug 25, 2022
View reviewed changes
Comment thread crates/pallet-token-claims/src/benchmarking.rs Outdated
@dmitrylavrenov dmitrylavrenov force-pushed the claims-integration-benchmark-run-blocks branch from f6be25a to 861e06a Compare August 25, 2022 15:35
Base automatically changed from claims-integration to master August 28, 2022 22:25
@MOZGIII MOZGIII linked an issue Aug 30, 2022 that may be closed by this pull request
Token claims and vesting benchmarks #447
Closed
@MOZGIII MOZGIII mentioned this pull request Aug 30, 2022
Closed
@dmitrylavrenov dmitrylavrenov changed the title Improve benchmark interfaces to emulate blocks running Token claims and vesting benchmarks Aug 31, 2022
@dmitrylavrenov dmitrylavrenov force-pushed the claims-integration-benchmark-run-blocks branch from 861e06a to f12c578 Compare August 31, 2022 11:24
@dmitrylavrenov
Copy link
Copy Markdown
Contributor Author

dmitrylavrenov commented Aug 31, 2022

@MOZGIII Could you please look on current implementation for pallet_token_claims benchmarking. Is it something that we would like to have?

MOZGIII
MOZGIII reviewed Aug 31, 2022
View reviewed changes
Comment thread crates/pallet-token-claims/src/benchmarking.rs
@dmitrylavrenov dmitrylavrenov force-pushed the claims-integration-benchmark-run-blocks branch from 2c7b389 to b16de0c Compare September 1, 2022 12:35
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/humanode-runtime/src/benchmarking.rs Outdated
@MOZGIII
Copy link
Copy Markdown
Contributor

MOZGIII commented Sep 1, 2022

Much better!

@dmitrylavrenov dmitrylavrenov marked this pull request as ready for review September 1, 2022 20:49
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/humanode-runtime/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/humanode-runtime/src/vesting.rs
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-token-claims/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I left a few comments, but other than that we should be good

MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-token-claims/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs Outdated
MOZGIII
MOZGIII reviewed Sep 1, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs
MOZGIII
MOZGIII reviewed Sep 2, 2022
View reviewed changes
Comment thread crates/pallet-vesting/src/benchmarking.rs Outdated
MOZGIII
MOZGIII approved these changes Sep 2, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Once we fix the clippy issue we can merge

@dmitrylavrenov @MOZGIII
Fix missing doc for prepare_init
7f3375e 
Co-authored-by: MOZGIII <mike-n@narod.ru>
@dmitrylavrenov dmitrylavrenov merged commit c3563c8 into master Sep 2, 2022
@dmitrylavrenov dmitrylavrenov deleted the claims-integration-benchmark-run-blocks branch September 2, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Token claims and vesting benchmarks

2 participants

@dmitrylavrenov @MOZGIII