Open
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the repository’s custom Kubernetes workload Terraform module now that the “Get started” tutorial uses the public Humanitec workload module, and updates Azure Terraform configuration to use the current azurerm_federated_identity_credential argument name.
Changes:
- Remove the in-repo
modules/workload/kubernetesimplementation (variables, main resources, outputs). - Update Azure
azurerm_federated_identity_credentialto useuser_assigned_identity_idinstead of the deprecatedparent_id.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| modules/workload/kubernetes/variables.tf | Removes module input variables as part of deleting the old workload module. |
| modules/workload/kubernetes/main.tf | Removes the Kubernetes Deployment-based workload implementation. |
| modules/workload/kubernetes/outputs.tf | Removes workload metadata output from the deleted module. |
| infra/azure/azure.tf | Updates federated identity credential configuration to newer AzureRM provider schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the "Get started" tutorial moving to the public workload module https://github.com/humanitec-tf-modules/k8s-workload-kubernetes instead of the tutorial's own implementation, this implementation can be removed from the present backing repo entirely.
Unrelated, but encountered during the update, the PR also changes a deprecated Azure TF provider property to the current one.