Skip to content

Use humanitec TF module#5

Open
TobiasBabin wants to merge 3 commits intomainfrom
use-humanitec-tf-modules
Open

Use humanitec TF module#5
TobiasBabin wants to merge 3 commits intomainfrom
use-humanitec-tf-modules

Conversation

@TobiasBabin
Copy link
Copy Markdown
Contributor

@TobiasBabin TobiasBabin commented Mar 30, 2026

⚠️ Do not merge before https://github.com/humanitec/developers-docs/pull/1480 is merged and published.

With the "Get started" tutorial moving to the public workload module https://github.com/humanitec-tf-modules/k8s-workload-kubernetes instead of the tutorial's own implementation, this implementation can be removed from the present backing repo entirely.

Unrelated, but encountered during the update, the PR also changes a deprecated Azure TF provider property to the current one.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the repository’s custom Kubernetes workload Terraform module now that the “Get started” tutorial uses the public Humanitec workload module, and updates Azure Terraform configuration to use the current azurerm_federated_identity_credential argument name.

Changes:

  • Remove the in-repo modules/workload/kubernetes implementation (variables, main resources, outputs).
  • Update Azure azurerm_federated_identity_credential to use user_assigned_identity_id instead of the deprecated parent_id.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
modules/workload/kubernetes/variables.tf Removes module input variables as part of deleting the old workload module.
modules/workload/kubernetes/main.tf Removes the Kubernetes Deployment-based workload implementation.
modules/workload/kubernetes/outputs.tf Removes workload metadata output from the deleted module.
infra/azure/azure.tf Updates federated identity credential configuration to newer AzureRM provider schema.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants