Skip to content

Conversation

@erlend-aasland
Copy link

@erlend-aasland erlend-aasland commented Jan 9, 2022

@hugovk hugovk changed the title Test stale-action, PR 1 Test stale-action, PR 1 - with "fake CLA not signed" label Jan 9, 2022
@hugovk
Copy link
Owner

hugovk commented Jan 10, 2022

Bump to explicitly reset activity timers.

@ambv
Copy link

ambv commented Jan 11, 2022

Both your last comment here and on issue 18 (I'm not tagging it deliberately to not retrigger its activity) were made over 24 hours ago. Nothing happened so far. Let's wait a while longer, maybe the stale actions only run once a day?

@ambv
Copy link

ambv commented Jan 11, 2022

Umm, I should have probably responded on the other PR :D Oh well.

@hugovk
Copy link
Owner

hugovk commented Jan 11, 2022

Haha yes, these comments have reset the activity timer on this PR :D

Well let's just leave them both as is (I won't reset the other), and let's comment on the upstream PR or issue in future :)


https://github.com/hugovk/cpython/runs/4769591131?check_suite_focus=true shows the cron did run last night (15 hours ago), and processed them correctly, for example:

  [#18] Days before pull request stale: 1

-> at the cron time there hadn't yet been one whole day of inactivity, so nothing happened yet, as expected.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing

@github-actions github-actions bot added the stale label Jan 13, 2022
@github-actions
Copy link

Closing this stale PR because the CLA is still not signed.

@github-actions github-actions bot closed this Jan 15, 2022
@hugovk
Copy link
Owner

hugovk commented Jan 15, 2022

Test successful!

Closed as expected. Commenting here to see if the stale label will be removed, though it's not important.

@erlend-aasland erlend-aasland deleted the patch-1 branch July 4, 2023 22:48
hugovk pushed a commit that referenced this pull request Dec 18, 2025
Grab builtins dict from module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants