[Fix] Stranded params - #46116
Closed
remi-or wants to merge 3 commits into
Closed
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
View the CircleCI Test Summary for this PR: https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=46116&sha=9d3f64 |
Collaborator
Author
|
Fixed in another PR, closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the new distributed loading scheme introduced in #45028 some parameters like RoPE's inv_freq may stay on CPU after the model is loaded. This is because the device map is None so
_move_missing_keys_from_meta_to_devicemoves those keys to the CPU as a default.This is not great because 1. it means we have host-to-device transfers in
forwardand 2. this crashes CUDA graphs captures.To fix this, in this context only (there is a device mesh but no device map) we use the current device as a fallback for those params.
This fixes TP2 in continuous batching.
Not sure I understand our model loading thoroughly so asking for a careful review here!