Cache merged_typed_dict to not break validate_typed_dict caching - #45807
Merged
Conversation
zucchini-nlp
reviewed
May 7, 2026
lgeiger
commented
May 7, 2026
zucchini-nlp
enabled auto-merge
May 7, 2026 11:30
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
louzongzhi
pushed a commit
to louzongzhi/transformers
that referenced
this pull request
May 11, 2026
…uggingface#45807) * Cache `merged_typed_dict` to not break `validate_typed_dict` caching * Set maxsize=8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#40793 introduced type validation
validate_typed_dictcalls the lru-cached_build_strict_cls_from_typed_dictfunction. However since we re-createmerged_typed_dicton every run this cache will always be ignore and recompute strict type dict. This can be slow.This PR fixes it by also caching the
merged_typed_dictcreation. Alternatively we could manually validate the two type dicts individually.Code Agent Policy
The Transformers repo is currently being overwhelmed by a large number of PRs and issue comments written by
code agents. We are currently bottlenecked by our ability to review and respond to them. As a result,
we ask that new users do not submit pure code agent PRs at this time.
You may use code agents in drafting or to help you diagnose issues. We'd also ask autonomous "OpenClaw"-like agents
not to open any PRs or issues for the moment.
PRs that appear to be fully agent-written will probably be closed without review, and we may block users who do this
repeatedly or maliciously.
This is a rapidly-evolving situation that's causing significant shockwaves in the open-source community. As a result,
this policy is likely to be updated regularly in the near future. For more information, please read
CONTRIBUTING.md.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
/cc @zucchini-nlp