chore(sec): added a handful of security checks#45462
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: auto, dia, ernie4_5, ernie4_5_vl_moe, hubert, sew, sew_d, videomt |
|
run-slow: auto, dia, ernie4_5, ernie4_5_vl_moe, hubert, sew, sew_d, videomt |
|
This comment contains models: ["models/auto", "models/dia", "models/ernie4_5", "models/ernie4_5_vl_moe", "models/hubert", "models/sew", "models/sew_d", "models/videomt"] |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| config.attention_dropout = fs_config.attention_dropout | ||
| config.conv_bias = False | ||
| conv_layers = eval(fs_config.extractor_conv_feature_layers) | ||
| conv_layers = ast.literal_eval(fs_config.extractor_conv_feature_layers) |
There was a problem hiding this comment.
I think this would work, so ok
| self._tmp_dir = tempfile.mkdtemp(prefix="dia_test_") | ||
| self.audio_prompt_1_path = os.path.join(self._tmp_dir, "dia_test_sample_1.mp3") | ||
| self.audio_prompt_2_path = os.path.join(self._tmp_dir, "dia_test_sample_2.mp3") |
There was a problem hiding this comment.
This is integration test (decoreated @slow) - make sure we run this before merge, although the change is small and clear.
|
In general, we don't need to touch the conversion scripts. But it's fine to keep the changes as you already did. |
|
let's review this once the migration is done 👍 🙏 |
What does this PR do?
Activated some bandit rules and fixed a few spots