Skip to content

Fix typo: necesary → necessary#43271

Open
Arthi706 wants to merge 1 commit into
huggingface:mainfrom
Arthi706:yaddayadda/learning-1
Open

Fix typo: necesary → necessary#43271
Arthi706 wants to merge 1 commit into
huggingface:mainfrom
Arthi706:yaddayadda/learning-1

Conversation

@Arthi706

Copy link
Copy Markdown

No description provided.

@Arthi706

Copy link
Copy Markdown
Author

I investigated the CI failure in IdeficsProcessorTest::test_save_load_pretrained_additional_features

The test passes locally:

pytest tests/models/idefics/test_processing_idefics.py -k test_save_load_pretrained_additional_features

This PR only updates comments/docstrings, so the CI failure appears unrelated/flaky.
Happy to rerun CI if needed.

@Rocketknight1 Rocketknight1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks for the fix!

@github-actions

Copy link
Copy Markdown
Contributor

View the CircleCI Test Summary for this PR:

https://huggingface.co/spaces/transformers-community/circle-ci-viz?pr=43271&sha=f314a9

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Rocketknight1

Copy link
Copy Markdown
Member

cc @ydshieh we definitely have some flaky tests here! Some of them look like Hub connection issues but I think we probably want to mark test_prompt_lookup_decoding_matches_greedy_search as flaky?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants