Skip to content

[Ernie 4.5 VL Moe] Post merge adjustments#43117

Merged
vasqu merged 1 commit into
huggingface:mainfrom
vasqu:fix-ernie-postmerge
Jan 6, 2026
Merged

[Ernie 4.5 VL Moe] Post merge adjustments#43117
vasqu merged 1 commit into
huggingface:mainfrom
vasqu:fix-ernie-postmerge

Conversation

@vasqu

@vasqu vasqu commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

As per title, relevant PRs

Note that grouped_mm in moe leads to small fluctuations making the integration tests flaky

@vasqu

vasqu commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator Author

cc @IlyasMoutawwakil re moe integration tests (fluctuations)

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: ernie4_5_vl_moe

@vasqu

vasqu commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator Author

run-slow: ernie4_5_vl_moe

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This comment contains run-slow, running the specified jobs:

models: ["models/ernie4_5_vl_moe"]
quantizations: []

@IlyasMoutawwakil IlyasMoutawwakil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vasqu !

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

CI Results

Workflow Run ⚙️

✅ No failing test specific to this PR 🎉 !

@zucchini-nlp zucchini-nlp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the follow up! atest should prob be eager by default for all models!

@vasqu

vasqu commented Jan 6, 2026

Copy link
Copy Markdown
Collaborator Author

Yea, lemme do a follow-up for the other moes - wasn't sure so waited for the nightly ci report

@vasqu
vasqu merged commit 52e9d05 into huggingface:main Jan 6, 2026
20 checks passed
@vasqu
vasqu deleted the fix-ernie-postmerge branch January 6, 2026 12:51
SangbumChoi pushed a commit to SangbumChoi/transformers that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants