Add clear error message for missing SentencePiece model in get_spm_processor (fix #41553)#41584
Open
AvinashDwivedi wants to merge 3 commits into
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: llama |
Author
|
@ArthurZucker would you please help me why I'm seeing checks are failing although the changes are very small. I'm new to opensource So, please help me sir! |
Member
|
I think it's strange to reference |
Collaborator
|
Copy pasting a bit but let's coordinate #41553 (comment) |
Author
|
@ArthurZucker @Rocketknight1 as I can see this issue is still not solved can you guys give me some idea how you want it? I'll make it exactly same as you want it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: clearer error when SentencePiece model file is missing for Llama tokenizer
Fix:
Improved error handling in get_spm_processor to provide a clear, actionable message when the required SentencePiece model file is missing.
Before:
The tokenizer raised an unhelpful low-level
from the SentencePiece library when vocab_file was None.
After:
It now raises a concise, human-readable error:
Fixes: #41553
