Fix equality-vs-assignment bug in GptqHfQuantizer.update_device_map#41304
Closed
gapsong wants to merge 1 commit into
Closed
Fix equality-vs-assignment bug in GptqHfQuantizer.update_device_map#41304gapsong wants to merge 1 commit into
gapsong wants to merge 1 commit into
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gptq |
MekkCyber
reviewed
Oct 8, 2025
MekkCyber
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix 🤗 ! Sorry a PR was already merged to fix this issue
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a typo in
GptqHfQuantizer.update_device_mapwhere an equality comparison (==) was used instead of an assignment (=). Due to this,device_mapwas never updated to CUDA when usingauto-gptq(which does not support CPU), leaving the model on CPU contrary to the intent expressed in the comment.GptqHfQuantizer.update_device_mapBefore:
After:
This change makes the code match the intended behavior: when
gptqmodelis not available and the model would otherwise be placed on CPU, move to CUDA device map ({"": 0}).Who can review?
Anyone in the community is also welcome to review.