Docs: Clarify rjieba installation for RoFormerTokenizer#40738
Open
dipanshuchoudhary-data wants to merge 1 commit into
Open
Docs: Clarify rjieba installation for RoFormerTokenizer#40738dipanshuchoudhary-data wants to merge 1 commit into
dipanshuchoudhary-data wants to merge 1 commit into
Conversation
Member
|
cc @stevhliu |
stevhliu
reviewed
Sep 8, 2025
stevhliu
left a comment
Member
There was a problem hiding this comment.
Thanks!
Can you revert all the other changes to the doc? Those aren't necessary and may break the doc-builder
| ```py | ||
| # uncomment to install rjieba which is needed for the tokenizer | ||
| # !pip install rjieba | ||
| # To use RoFormerTokenizer, first install `rjieba`: |
Member
There was a problem hiding this comment.
Let's move this above the <hfoptions> blocks.
Suggested change
| # To use RoFormerTokenizer, first install `rjieba`: | |
| Install [rjieba](https://github.com/messense/rjieba-py) with the following command to use [`RoFormerTokenizer`]. | |
| <tadd code here> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the RoFormer documentation by clearly explaining how to install
rjiebabefore using RoFormerTokenizer. Previously the install command was either missing or commented
out, which could confuse new users. This update adds proper
pip install rjiebacode blocksin both Pipeline and AutoModel examples.