Fix check_quantized_param method when param_value is a safetensors slice#40425
Open
radulescupetru wants to merge 3 commits into
Open
Fix check_quantized_param method when param_value is a safetensors slice#40425radulescupetru wants to merge 3 commits into
radulescupetru wants to merge 3 commits into
Conversation
4 tasks
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: bnb, eetq_integration, fbgemm_fp8, finegrained_fp8, higgs |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a case where when loading a quantized model from safetensors with tensor parallelism enabled (
device_mesh!=None) ,check_quantized_param(...)method was failing as it was expecting a torch.Tensor as input forparam_valueand it was supplied with aslice.More details: #40361
Fixes #40361
Before submitting
Pull Request section?
to it if that's the case. - Quantized model loading failing with custom device mesh #40361
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@SunMarc @S1ro1