Enable PLW and PLE rules#40265
Draft
cyyever wants to merge 1 commit into
Draft
Conversation
cyyever
marked this pull request as draft
August 19, 2025 06:16
cyyever
marked this pull request as ready for review
August 19, 2025 07:43
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
3 times, most recently
from
August 19, 2025 08:23
673bf3d to
ff3fc97
Compare
cyyever
marked this pull request as draft
August 19, 2025 08:32
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
2 times, most recently
from
August 19, 2025 08:45
67723cc to
85c0850
Compare
cyyever
marked this pull request as ready for review
August 19, 2025 08:57
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
August 19, 2025 09:05
85c0850 to
1404625
Compare
Member
|
Since this adds new Ruff rules, cc @ArthurZucker @Cyrilvallez as core maintainers! |
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
August 20, 2025 18:44
42b629b to
f51cd77
Compare
Contributor
Author
|
@ArthurZucker It is green |
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
September 5, 2025 16:27
a26c17e to
70123dd
Compare
Cyrilvallez
reviewed
Sep 8, 2025
Cyrilvallez
left a comment
Member
There was a problem hiding this comment.
These rules seem a bit cumbersome/weird, please explain more as we don't want to have to add noqa comments everywhere for no reason
|
|
||
|
|
||
| class PretrainedConfig(PushToHubMixin): | ||
| class PretrainedConfig(PushToHubMixin): # noqa: PLW1641 |
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
2 times, most recently
from
September 24, 2025 02:19
8c5c25f to
1d582ef
Compare
cyyever
marked this pull request as draft
September 24, 2025 04:14
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
2 times, most recently
from
September 24, 2025 11:49
9930c43 to
02844f5
Compare
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
3 times, most recently
from
October 5, 2025 03:59
77c0088 to
e936815
Compare
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
October 19, 2025 02:37
e936815 to
3827d72
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: depth_pro, marian |
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
October 19, 2025 02:40
3827d72 to
35399ae
Compare
Signed-off-by: Yuanyuan Chen <cyyever@outlook.com>
cyyever
force-pushed
the
fix_pl_warnings_for_model
branch
from
October 19, 2025 02:44
35399ae to
2c7b4a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable ruff
PLWandPLErules, which implement warnings and errors of Pylint.