fix colpali mapping#39353
Open
ManuelFay wants to merge 2 commits into
Open
Conversation
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: colpali |
Contributor
Author
|
@yonigozlan This fails because of the modular that copies over the mapping to ColQwen2 (which does not need it). |
zucchini-nlp
left a comment
Member
There was a problem hiding this comment.
Thanks, I already had a fix here #39242 which is waiting for core maintainer's review :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Fixes the issue of Colpali not working sincer the breaking changes with VLMs in 4.52.
Most models were converted, not the native HF colpali making the code in docs here fail: https://huggingface.co/docs/transformers/model_doc/colpali.
@yonigozlan @zucchini-nlp