Add kyutai stt#38909
Merged
Merged
Conversation
eustlb
commented
Jun 23, 2025
eustlb
left a comment
Collaborator
Author
There was a problem hiding this comment.
@ArthurZucker commented below the last changes that require your validation 🤗
Comment on lines
+4660
to
+4664
| # Update: to extend _keep_in_fp32_modules flag feature, it can also be used to force modules that should stay in fp32 | ||
| if model._keep_in_fp32_modules is not None and ( | ||
| torch_dtype == torch.float16 or getattr(hf_quantizer, "use_keep_in_fp32_modules", False) | ||
| torch_dtype == torch.float16 | ||
| or torch_dtype == torch.bfloat16 | ||
| or getattr(hf_quantizer, "use_keep_in_fp32_modules", False) |
Collaborator
Author
There was a problem hiding this comment.
as discussed offline, let's extend _keep_in_fp32_modules for more intuitive fonctionning
| "processing", | ||
| "image_processing", | ||
| "video_processing", | ||
| "feature_extractor", |
Collaborator
Author
There was a problem hiding this comment.
discussed offline with @Cyrilvallez, the correct convention for now for file naming is feature_extraction yet I do agree that feature_extractor sounds better. Nonetheless let's keep it how it is for know for coherency
Collaborator
|
Yes let's go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Kyutai's new STT model 🚀