Add support to use config dtype in HybridChunkedCache#38908
Open
vivekkhandelwal1 wants to merge 1 commit into
Open
Add support to use config dtype in HybridChunkedCache#38908vivekkhandelwal1 wants to merge 1 commit into
vivekkhandelwal1 wants to merge 1 commit into
Conversation
Signed-off-by: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
Contributor
Author
|
Hi @ydshieh @Rocketknight1! It would be great if you can find some time to review this change. |
Member
|
cc @gante |
Contributor
Author
|
Hi @gante, can you please review this PR? |
Contributor
|
I don't think this is the right solution: Would you be able to expand the description of the issue you're seeing? I might be able to provide solutions 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the issue with the HybridChunkedCache initialisation since it does not consider the dtype present in the model config. Here:
transformers/src/transformers/cache_utils.py
Line 1806 in b949747