update utils/notification_service.py for AMD vs Nvidia#38563
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
mht-sharma
reviewed
Jun 4, 2025
| # if `commit_sha` is specified, and `workflow_run["head_sha"]` matches it, return it. | ||
| elif commit_sha not in [None, ""] and run["head_sha"] == commit_sha: | ||
| # if `commit_sha` is specified, return the latest completed run with `workflow_run["head_sha"]` matching the specified sha. | ||
| elif commit_sha not in [None, ""] and run["head_sha"] == commit_sha and run["status"] == "completed": |
Contributor
There was a problem hiding this comment.
run["head_sha"] == commit_sha The commit_sha could be different for AMD and NVIDIA?
Collaborator
Author
There was a problem hiding this comment.
No, each day, the scheduled CIs (Nvidia / AMD) are triggered at (almost) the same time, and the associated commit SHA is the latest commit SHA on main at that time.
For example, see today's run (the caller being triggered)
https://github.com/huggingface/transformers/actions/runs/15432439509
(AMD)
and
https://github.com/huggingface/transformers/actions/runs/15432421302
(Nvidia)
On those 2 pages, you will see 78d771
mht-sharma
approved these changes
Jun 4, 2025
bvantuan
pushed a commit
to bvantuan/transformers
that referenced
this pull request
Jun 12, 2025
…#38563) update Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As discussed with @mht-sharma