Fix deepseekv3#38562
Conversation
| ] | ||
| super().test_past_key_values_format(custom_all_cache_shapes=all_cache_shapes) | ||
|
|
||
| @require_torch_large_accelerator |
There was a problem hiding this comment.
And from time to time, this OOM affect subsequent tests (that will pass if this test is not OOM)
| "Simply put, the theory of relativity states that Frojekecdytesాలు sicʰtinaccianntuala breej的效率和质量的控制lavestock-PraccuraciesOTTensorialoghismos的思路astiomotivityosexualriad TherapeuticsoldtYPEface Kishsatellite-TV", | ||
| "My favorite all time favorite condiment is ketchup.ieden沟渠係室温 Fryrok般地Segmentation Cycle/physicalwarenkrautempsాలు蹈梗 Mesomac一等asan lethality suspended Causewaydreamswith Fossilsdorfాలు蹈 ChristiansenHOMEbrew", |
There was a problem hiding this comment.
Already failing when the model is added. Don't know what machine was used when this test is written. The updated value works for both T4 and A10, but it looks like gibberish.
@bzantium If you know some details back then?
There was a problem hiding this comment.
There is this comment above with
# Note on `EXPECTED_TEXT_COMPLETION`'s diff: the current value matches the original test if the original test
# was changed to have a cache of 53 tokens (as opposed to 4096), on Ampere GPUs.
Not sure what they did there then tho
|
There are still 2 remaining issues (failing since the day when the model is added) cc @gante when you have the bandwidth. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
vasqu
left a comment
There was a problem hiding this comment.
I don't think it makes sense to change the values just to make the tests happy here. My gripe is that the output is too gibberish - I'd like to hear from @bzantium
If there is no response, I'm ok with changing it under a TODO / extra note of what the previous value has been.
| "Simply put, the theory of relativity states that Frojekecdytesాలు sicʰtinaccianntuala breej的效率和质量的控制lavestock-PraccuraciesOTTensorialoghismos的思路astiomotivityosexualriad TherapeuticsoldtYPEface Kishsatellite-TV", | ||
| "My favorite all time favorite condiment is ketchup.ieden沟渠係室温 Fryrok般地Segmentation Cycle/physicalwarenkrautempsాలు蹈梗 Mesomac一等asan lethality suspended Causewaydreamswith Fossilsdorfాలు蹈 ChristiansenHOMEbrew", |
There was a problem hiding this comment.
There is this comment above with
# Note on `EXPECTED_TEXT_COMPLETION`'s diff: the current value matches the original test if the original test
# was changed to have a cache of 53 tokens (as opposed to 4096), on Ampere GPUs.
Not sure what they did there then tho
vasqu
left a comment
There was a problem hiding this comment.
Thanks :) perfect, then let's add a comment for clarification and then it's good to go
* fix 1 * fix 2 * fix 3 * fix 4 * update --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
What does this PR do?
See comments on the PR changes