Remove type annotation in Siglip Attention Module#38503
Merged
Conversation
Contributor
Author
|
@yonigozlan Please review this NIT PR |
yonigozlan
approved these changes
Jun 2, 2025
Contributor
There was a problem hiding this comment.
Ok for removing if it can help using SigLip2 with modular. Wdyt @ydshieh ?
ydshieh
approved these changes
Jun 2, 2025
ydshieh
left a comment
Collaborator
There was a problem hiding this comment.
OK, makes sense, thank you
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the title, it removes the type annotation that causes issues when using Modular as we don't usually have both text and vision config for all the models. Since SigLIP is commonly used in VLMs as vision backbone, and the Attention module is a quite generic so this allows us more flexibility in using Modular.