Skip to content

Name change AOPermod -> ModuleFqn#38456

Merged
SunMarc merged 6 commits into
huggingface:mainfrom
drisspg:switch-name
Jun 3, 2025
Merged

Name change AOPermod -> ModuleFqn#38456
SunMarc merged 6 commits into
huggingface:mainfrom
drisspg:switch-name

Conversation

@drisspg

@drisspg drisspg commented May 28, 2025

Copy link
Copy Markdown
Contributor

We did not yet publish this API in a major release, and we have changed the name

@jerryzh168

Copy link
Copy Markdown
Contributor

cc @MekkCyber @SunMarc can you take a look

@SunMarc SunMarc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update !

@drisspg

drisspg commented May 30, 2025

Copy link
Copy Markdown
Contributor Author

@SunMarc Anything else I need to do?

@MekkCyber MekkCyber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good ! Thanks for upstreaming the changes

@SunMarc SunMarc enabled auto-merge (squash) June 2, 2025 14:02
@drisspg

drisspg commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

@MekkCyber @SunMarc I am not totally sure how to run the required CI jobs?

@SunMarc

SunMarc commented Jun 3, 2025

Copy link
Copy Markdown
Member

I've triggered the tests ! I'll make sure to merge this asap

@SunMarc SunMarc merged commit 279000b into huggingface:main Jun 3, 2025
20 checks passed
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

bvantuan pushed a commit to bvantuan/transformers that referenced this pull request Jun 12, 2025
Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
Co-authored-by: Mohamed Mekkouri <93391238+MekkCyber@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants