Skip to content

[tests] remove overload for deleted test (test_offloaded_cache_implementation)#37896

Merged
gante merged 3 commits into
huggingface:mainfrom
gante:rm_deleted_test_overload
May 27, 2025
Merged

[tests] remove overload for deleted test (test_offloaded_cache_implementation)#37896
gante merged 3 commits into
huggingface:mainfrom
gante:rm_deleted_test_overload

Conversation

@gante

@gante gante commented Apr 30, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

test_offloaded_cache_implementation was deleted in #37724

This PR deletes stray overloads (which were skipping the test)

@github-actions
github-actions Bot marked this pull request as draft April 30, 2025 15:25
@github-actions

Copy link
Copy Markdown
Contributor

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@gante
gante marked this pull request as ready for review April 30, 2025 15:25
@gante
gante requested a review from Rocketknight1 April 30, 2025 15:26
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@gante
gante requested a review from ydshieh May 26, 2025 15:17

@ydshieh ydshieh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gooooooooood!

@gante
gante merged commit 0f5a824 into huggingface:main May 27, 2025
@gante
gante deleted the rm_deleted_test_overload branch May 27, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants