notify new model merged to main - #36375
Merged
Merged
Conversation
ydshieh
commented
Feb 24, 2025
|
|
||
|
|
||
| def get_new_python_files() -> List[str]: | ||
| def get_new_python_files(diff_with_last_commit=False) -> List[str]: |
Collaborator
Author
There was a problem hiding this comment.
Use diff_with_last_commit to indiciate we are compare files in main (head vs parent)
ydshieh
commented
Feb 24, 2025
| shell: bash | ||
| run: | | ||
| python -m pip install gitpython | ||
| python -c 'from utils.pr_slow_ci_models import get_new_model; new_model = get_new_model(diff_with_last_commit=True); print(new_model)' | tee output.txt |
Collaborator
Author
There was a problem hiding this comment.
on main, we need to use diff_with_last_commit=True
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notify new model PR being merged to
main