Avoid calling get_max_length - #34971
Merged
Merged
Conversation
Collaborator
Author
Might be flaky (1 failed in 100 run in my last check). I will look at this but open another PR for it. |
ArthurZucker
approved these changes
Nov 27, 2024
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
🫡 thanks for adressing!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
fix Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some tests are failing after #34247 as they are calling
get_max_lengthwhich callslogger, and torch dynamo hate it withLet's just call
get_max_cache_shapeasget_max_lengthis justlogger + get_max_cache_shapePaliGemmaForConditionalGenerationModelTest::test_generate_with_static_cacheandtests/models/granite/test_modeling_granite.py::GraniteModelTest::test_generate_from_inputs_embeds_with_static_cacheare passing now butstill has data dependent operation issue and failed. That should be addressed in a separate PR.