[MLU] remove deepspeed-mlu dependency - #34362
Open
Andy666G wants to merge 2 commits into
Open
Conversation
5 tasks
SunMarc
self-requested a review
October 24, 2024 12:58
SunMarc
previously approved these changes
Oct 24, 2024
SunMarc
left a comment
Member
There was a problem hiding this comment.
Nice ! Thanks for your work on mlu and deepspeed !
Member
|
The CI failing is unrelated to this PR ! |
SunMarc
reviewed
Oct 24, 2024
Comment on lines
-42
to
-44
| if is_torch_mlu_available(): | ||
| _ = importlib_metadata.metadata("deepspeed-mlu") | ||
| return True |
Member
There was a problem hiding this comment.
This is indeed not required anymore with the latest version of deepspeed but it will be breaking for users that doesn't have it yet ! If you don't want to rely on deepspeed-mlu anymore, you should inform the users that they need to install the latest deepspeed
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove deepspeed-mlu dependency. # (deepspeedai/DeepSpeed#6472)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@muellerzr @SunMarc