Skip to content

fix DAC slow test - #32879

Closed
kamilakesbi wants to merge 5 commits into
huggingface:mainfrom
kamilakesbi:fix_dac_slow_test
Closed

fix DAC slow test#32879
kamilakesbi wants to merge 5 commits into
huggingface:mainfrom
kamilakesbi:fix_dac_slow_test

Conversation

@kamilakesbi

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR aims to fix the slow test test_integration_24khz in DAC, recently added with PR #31494.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@amyeroberts

Copy link
Copy Markdown
Contributor

@kamilakesbi To run the slow model tests, you need to add the run-slow label to the PR. The order has to be label, then commit, so you'll need to push a [run_slow] commit again

@amyeroberts

Copy link
Copy Markdown
Contributor

@kamilakesbi To run the slow tests for this model, you need to pass the model name in the commit message i.e. [run_slow] dac

@ylacombe

ylacombe commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Hey @kamilakesbi, many thanks for opening this PR!
Do you think you'll be able to finish it? If not, it would be of a tremendous help if you could provide a simple snippet on the original DAC library so that I can take a look myself!

@ylacombe

Copy link
Copy Markdown
Contributor

supersede by #34088

@ylacombe ylacombe closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants