Reimplement "Automatic safetensors conversion when lacking these files" - #29846
Merged
Conversation
* Automatic safetensors conversion when lacking these files * Remove debug * Thread name * Typo * Ensure that raises do not affect the main thread
LysandreJik
force-pushed
the
safetensors-step-2
branch
from
March 25, 2024 09:13
a3d54cd to
9a7bcb2
Compare
LysandreJik
marked this pull request as ready for review
March 25, 2024 09:15
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Mar 26, 2024
ArthurZucker
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Could you link the two issues that raised the failures? 🤗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #29390 was reverted as it was failing in users' runtime.
Two past issues:
This PR enables it with a slight change: all exceptions can be caught and ignored so as to leave the user's runtime alone.