Byebye torch 1.10#28207
Merged
Merged
Conversation
73fe085 to
a974f21
Compare
a974f21 to
8669984
Compare
ArthurZucker
approved these changes
Jan 11, 2024
Collaborator
There was a problem hiding this comment.
tolerances where not updated 👿
Collaborator
Author
There was a problem hiding this comment.
which tolerances you mean? I am not able to see the line
Collaborator
There was a problem hiding this comment.
Just the TODO said update the tolerance after the CI moves to torch 1.10
Collaborator
Author
There was a problem hiding this comment.
oh yes. Sorry. However I don't have the full context about this ... and we need @anton-l for the change if necessary
LysandreJik
approved these changes
Jan 11, 2024
Collaborator
Author
|
OK, going to merge. Feel free to drop a more detailed comment on tolerances if it's something needs to be fixed. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Byebye torch 1.10 ☃️