Add exllamav2 better#27111
Merged
Merged
Conversation
SunMarc
commented
Oct 27, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
Member
Author
|
Since @ArthurZucker is out next week, it would be great if you could review this PR @amyeroberts. I'm trying to have this PR in the next release. In this modified version, I make sure to deprecate |
amyeroberts
reviewed
Oct 30, 2023
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding this!
Two general comments:
- Having two additional config arguments isn't ideal. There should be ideally a single parameter which configures this behaviour and is "off" when not set
- There needs to be argument verification for safe deprecation of the old flag
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
…nsformers into add_exllamav2_better
Member
Author
|
Thanks for the review @amyeroberts . I've addressed all the points. LMK if something is missing ! |
amyeroberts
reviewed
Oct 31, 2023
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Thanks for iterating on this!
There's at least one more iteration of the input argument logic - but we're close! Otherwise code and PR looks v. good
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Member
Author
|
Thanks for the deep review @amyeroberts ! I've added the input logic and simplified the link with optimum config. |
amyeroberts
approved these changes
Nov 1, 2023
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Great - thanks for the work iterating on this!
Just a few nits were the docs need to be updated. Otherwise LGTM!
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Member
Author
|
Thanks again @amyeroberts for iterating on this PR in such a short time ! |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* add_ xllamav2 arg * add test * style * add check * add doc * replace by use_exllama_v2 * fix tests * fix doc * style * better condition * fix logic * add deprecate msg * deprecate exllama * remove disable_exllama from the linter * remove * fix warning * Revert the commits deprecating exllama * deprecate disable_exllama for use_exllama * fix * fix loading attribute * better handling of args * remove disable_exllama from init and linter * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * better arg * fix warning * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * switch to dict * Apply suggestions from code review Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * style * nits * style * better tests * style --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR is a modified version of this PR that make
disable_exllamago through a deprecation cycle.I also fixed the following test
test_device_and_dtype_assignmentthat broke other tests in the CI introduced by this PR.I confirm that all the tests are green