Skip to content

Update tokenization_code_llama_fast.py#26576

Merged
ArthurZucker merged 3 commits into
huggingface:mainfrom
andyl98:codellama_fast_tokenizer_infilling_fix
Oct 6, 2023
Merged

Update tokenization_code_llama_fast.py#26576
ArthurZucker merged 3 commits into
huggingface:mainfrom
andyl98:codellama_fast_tokenizer_infilling_fix

Conversation

@andyl98

@andyl98 andyl98 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes the issue: #26575

Before submitting

Who can review?

@ArthurZucker

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Let's add a test! 😉

@andyl98

andyl98 commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Added some unit tests :)

@andyl98
andyl98 requested a review from ArthurZucker October 4, 2023 20:48

@ArthurZucker ArthurZucker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch! Looks good to me

@ArthurZucker
ArthurZucker merged commit 65aabaf into huggingface:main Oct 6, 2023
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants