Skip to content

Add TFDebertaV2ForMultipleChoice#25932

Merged
Rocketknight1 merged 8 commits into
huggingface:mainfrom
raghavanone:fix_issue_25537
Sep 5, 2023
Merged

Add TFDebertaV2ForMultipleChoice#25932
Rocketknight1 merged 8 commits into
huggingface:mainfrom
raghavanone:fix_issue_25537

Conversation

@raghavanone

@raghavanone raghavanone commented Sep 3, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes #25537

Add TFDebertaV2ForMultipleChoice model

@ArthurZucker

@amyeroberts

Copy link
Copy Markdown
Contributor

cc @Rocketknight1

@Rocketknight1 Rocketknight1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Seems like a clean port of the BERT code to DeBERTa-v2. One nitpick where a docstring wasn't changed, but other than that I think this is ready to merge!

Comment thread src/transformers/models/deberta_v2/modeling_tf_deberta_v2.py Outdated
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@raghavanone

Copy link
Copy Markdown
Contributor Author

@Rocketknight1 Not sure why this test fails.

@Rocketknight1

Copy link
Copy Markdown
Member

That test is an issue with the CI rather than this PR, you can ignore it! Are you ready for me to merge now?

@raghavanone

Copy link
Copy Markdown
Contributor Author

That test is an issue with the CI rather than this PR, you can ignore it! Are you ready for me to merge now?

Yes

@Rocketknight1

Rocketknight1 commented Sep 5, 2023

Copy link
Copy Markdown
Member

Ugh, it won't let me merge, which means we'll need to rebase to get the tests working. Can you:

  1. Pull the latest changes to your fork's main branch
  2. In your local working repo, git checkout main and git pull to ensure your local main branch is up to date
  3. In your local repo, git checkout fix_issue_25537 and then git pull and git rebase main to rebase onto the latest main branch
  4. Finally, git push --force to upload the rebased branch to Github

After that, tests should pass!

@raghavanone

Copy link
Copy Markdown
Contributor Author

Ugh, it won't let me merge, which means we'll need to rebase to get the tests working. Can you:

  1. Pull the latest changes to your fork's main branch
  2. In your local working repo, git checkout main and git pull to ensure your local main branch is up to date
  3. In your local repo, git checkout fix_issue_25537 and then git pull and git rebase main to rebase onto the latest main branch
  4. Finally, git push --force to upload the rebased branch to Github

After that, tests should pass!

Done, Lets hope the test passes.

@Rocketknight1

Copy link
Copy Markdown
Member

Looks like everything's passing now - sorry about the CI issues, and thanks for a very clean and useful PR!

@Rocketknight1 Rocketknight1 merged commit 1110b56 into huggingface:main Sep 5, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* Add TFDebertaV2ForMultipleChoice

* Import newer model in main init

* Fix import issues

* Fix copies

* Add doc

* Fix tests

* Fix copies

* Fix docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ValueError: Unrecognized configuration class <class>

4 participants