Skip to content

Generate: TF contrastive search must pop use_cache from model_kwargs - #21149

Merged
gante merged 1 commit into
huggingface:mainfrom
gante:contrastive_pop_use_cache
Jan 17, 2023
Merged

Generate: TF contrastive search must pop use_cache from model_kwargs#21149
gante merged 1 commit into
huggingface:mainfrom
gante:contrastive_pop_use_cache

Conversation

@gante

@gante gante commented Jan 17, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes a slow test that broke with #20994

(actually, more like ~25 slow tests 😅 )

@gante
gante requested review from sgugger and ydshieh January 17, 2023 11:19
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Jan 17, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@ydshieh ydshieh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's generate in 2023! Thanks 🔥

@gante
gante merged commit 7b5e943 into huggingface:main Jan 17, 2023
@gante
gante deleted the contrastive_pop_use_cache branch January 17, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants