Skip to content

fix levit timm conversion file - #20938

Merged
sgugger merged 3 commits into
huggingface:mainfrom
Bearnardd:fix_levit_conversion_file
Jan 6, 2023
Merged

fix levit timm conversion file#20938
sgugger merged 3 commits into
huggingface:mainfrom
Bearnardd:fix_levit_conversion_file

Conversation

@Bearnardd

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes conversion file convert_levit_timm_to_pytorch.py for levit

Fixes # (issue)
#20937

Who can review?

@NielsRogge

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Dec 29, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@CloudInnovator CloudInnovator left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes follow convention and all tests passed.

action="store_false",
help="Do not push model and feature extractor to the hub",
)
parser.set_defaults(push_to_hub=True)

@NielsRogge NielsRogge Jan 5, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) I'm not using this line in any conversion script

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NielsRogge removed.

@NielsRogge NielsRogge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@sgugger
sgugger merged commit f93c90d into huggingface:main Jan 6, 2023
@sgugger

sgugger commented Jan 6, 2023

Copy link
Copy Markdown
Collaborator

Thanks again for your contribution!

silverriver pushed a commit to silverriver/transformers that referenced this pull request Jan 6, 2023
* fix levit timm conversion file

* remove set_defaults
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants