Skip to content

[Docs] Add resources of OpenAI GPT#20084

Merged
sgugger merged 8 commits into
huggingface:mainfrom
shogohida:add-resources-of-openai-gpt
Nov 16, 2022
Merged

[Docs] Add resources of OpenAI GPT#20084
sgugger merged 8 commits into
huggingface:mainfrom
shogohida:add-resources-of-openai-gpt

Conversation

@shogohida

@shogohida shogohida commented Nov 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds resources of OpenAI GPT according to this issue

Fixes #20055 (partially)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@shogohida shogohida mentioned this pull request Nov 6, 2022
Closed
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 6, 2022

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sgugger sgugger requested a review from stevhliu November 7, 2022 14:55
stevhliu
stevhliu reviewed Nov 7, 2022
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @shogohida! 👍

If you can also add the relevant scripts and notebooks for the tasks your model is capable of, that'd be awesome!

Comment thread docs/source/en/model_doc/openai-gpt.mdx Outdated
Comment thread docs/source/en/model_doc/openai-gpt.mdx Outdated
@stevhliu stevhliu mentioned this pull request Nov 7, 2022
Closed
20 tasks
@shogohida shogohida marked this pull request as ready for review November 13, 2022 19:50
@shogohida

shogohida commented Nov 13, 2022

Copy link
Copy Markdown
Contributor Author

Hi @stevhliu, I added relevant scripts and notebooks so please have a look!

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 13, 2022

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu reviewed Nov 14, 2022
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for adding those. Now you just have a few more to go! 😁

Take a look at the OpenAI GPT2 resources page and feel free to add over whatever is missing here since the usage for OpenAI GPT is practically the same.

Comment thread docs/source/en/model_doc/openai-gpt.mdx Outdated
Comment thread docs/source/en/model_doc/openai-gpt.mdx Outdated
@shogohida @stevhliu
Update docs/source/en/model_doc/openai-gpt.mdx
051cc90 
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 15, 2022

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@shogohida shogohida requested a review from stevhliu November 15, 2022 12:55
@shogohida

shogohida commented Nov 15, 2022

Copy link
Copy Markdown
Contributor Author

@stevhliu
I changed the doc following your comments! Please have a look

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Nov 15, 2022

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

stevhliu
stevhliu reviewed Nov 15, 2022
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for iterating and improving this, just one last change and I think we're good to go!

Comment thread docs/source/en/model_doc/openai-gpt.mdx Outdated
@shogohida shogohida requested a review from stevhliu November 16, 2022 11:21
stevhliu
stevhliu approved these changes Nov 16, 2022
View reviewed changes

@stevhliu stevhliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for your contribution! Pinging @sgugger for a final look :)

sgugger
sgugger approved these changes Nov 16, 2022
View reviewed changes

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 3897022 into huggingface:main Nov 16, 2022
@shogohida shogohida deleted the add-resources-of-openai-gpt branch November 16, 2022 21:00
@shogohida

shogohida commented Nov 16, 2022

Copy link
Copy Markdown
Contributor Author

@stevhliu @sgugger
Thanks for your review! Hope to contribute more to transformers!

mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
@shogohida @stevhliu
[Docs] Add resources of OpenAI GPT (huggingface#20084)
a28961b 
* Add resources of OpenAI GPT

* Delete Deploy section and add .

* Add scripts

* Update docs/source/en/model_doc/openai-gpt.mdx

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>

* Delete causal-language-modeling section

* Add TFOpenAIGPTLMHeadModel

* Add resources from community

* Delete a link

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
@wonhyeongseo wonhyeongseo mentioned this pull request Aug 16, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevhliu stevhliu stevhliu approved these changes
+1 more reviewer
@sgugger sgugger sgugger approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Model resources contribution

4 participants

@shogohida @HuggingFaceDocBuilderDev @sgugger @stevhliu