[Test] Fix redirected links issue - #18542
Closed
younesbelkada wants to merge 3 commits into
Closed
Conversation
- get redirected link and replace it with correct repo id
- use BaseException to catch all errors - make style
|
The documentation is not available anymore as the PR was closed or merged. |
- use `BaseException` - use `.replace` instead of complicated `.split()`
Member
|
This should be fixed upstream (there's an open issue IIRC) |
Contributor
Author
|
Okay I see! I think that you are referring to this issue: #17582 posting it here for visibility! EDIT: it will be fixed once |
Collaborator
|
It should be fixed on the Hugging Face Hub side at this stage (the issue reported incorrectly that it works for |
Member
|
note that in the meantime you can always opt to re-rename your repos if it's a big issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR tries to address the issue of loading a model when the original link is redirected. This happened for BLOOM models where the repo ids has been changed but the code does not take into account redirected links.
I am not sure how to properly test if this does not break anything so I am putting this PR as a test PR, so feel free to ignore it.
Now loading BLOOM models with old naming works
Also this can be done probably on the
huggingface_hublevel but I am not sureRelated to #18531