[Gradient checkpoining] Update Wav2Vec scripts - #14036
Conversation
|
FYI, this is a duplicate of #13964, but I think yours is better since mine doesn't change the flax example. |
|
Hi and sorry for the duplicate. I checked for similar issues but forgot to search for PRs. Besides the missed flax example, #13964 possibly runs into this warning: The present PR follows the recommendation from Performance#Gradient Checkpointing. |
|
No need to be sorry, I was just pointing to maintainers that there are 2 of the kind so it's easy to deal with them at once. Further, #13877 moved wav2vec2 to supported examples, but for some reason these examples didn't get ported. |
|
Well noted, the addition of As I understood, run_wav2vec2_pretraining_no_trainer.py is equivalent to Nonetheless, there seems to be some duplicated work in, e.g., argument parsing, dataset setup, and model instantiation. It is also not clear whether the notes in |
|
@patrickvonplaten, we had 2 similar PRs. #13964 got merged and this one has one more file covered that mine didn't. I rebased it to incorporate the changes from the other PR. |
|
Thanks for updating the scripts! |
What does this PR do?
This PR makes the Wav2Vec scripts compatible with the changes introduced in #13657 regarding the
gradient_checkpointingfeature/argument.Before submitting
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@stas00, @LysandreJik, @patrickvonplaten