Skip to content

[deepspeed] replaced deprecated init arg#13587

Merged
stas00 merged 3 commits into
huggingface:masterfrom
stas00:ds-init-config
Sep 16, 2021
Merged

[deepspeed] replaced deprecated init arg#13587
stas00 merged 3 commits into
huggingface:masterfrom
stas00:ds-init-config

Conversation

@stas00

@stas00 stas00 commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

deepspeed 0.5.2 deprecated config in zero.Init() in favor of config_dict_or_path - deepspeed 0.5.3 fixed a bug in the previous version related to that deepspeedai/DeepSpeed#1373. So this PR updates the arg and ups the minimal requirement.

0.5.3 fixes a bug in zero_to_fp32.py introduced by 0.5.2

The ci failure is unrelated.

@sgugger, @LysandreJik

@stas00
stas00 marked this pull request as ready for review September 16, 2021 18:49

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating!

@stas00
stas00 merged commit bec2e3f into huggingface:master Sep 16, 2021
@stas00
stas00 deleted the ds-init-config branch September 16, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants