Skip to content

Pin git python to <3.1.19#12858

Merged
patrickvonplaten merged 19 commits into
huggingface:masterfrom
patrickvonplaten:pin_git_python
Jul 23, 2021
Merged

Pin git python to <3.1.19#12858
patrickvonplaten merged 19 commits into
huggingface:masterfrom
patrickvonplaten:pin_git_python

Conversation

@patrickvonplaten

@patrickvonplaten patrickvonplaten commented Jul 23, 2021

Copy link
Copy Markdown
Contributor

What does this PR do?

GitPython did a new release which breaks our tests: https://github.com/gitpython-developers/GitPython/pull/1275/files
See: https://app.circleci.com/pipelines/github/huggingface/transformers/26010/workflows/a72a068e-b3f0-42e1-b08b-7e2c89cae3ed/jobs/245943 for example.

Pinning GitPython for now to make circle ci work

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@patrickvonplaten

Copy link
Copy Markdown
Contributor Author

@patrickvonplaten
patrickvonplaten merged commit e218249 into huggingface:master Jul 23, 2021
@patrickvonplaten
patrickvonplaten deleted the pin_git_python branch July 23, 2021 12:16
@patrickvonplaten patrickvonplaten changed the title Pin git python to <3.10.0 Pin git python to <3.1.19 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant