Skip to content

Update object detection guide#493

Open
qubvel wants to merge 1 commit into
huggingface:mainfrom
qubvel:update-object-detection-guide
Open

Update object detection guide#493
qubvel wants to merge 1 commit into
huggingface:mainfrom
qubvel:update-object-detection-guide

Conversation

@qubvel

@qubvel qubvel commented May 9, 2024

Copy link
Copy Markdown

What does this PR do?

Update object detection guide notebook according to recent changes
huggingface/transformers#30683

Who can review?

@NielsRogge

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NielsRogge NielsRogge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@qubvel

qubvel commented May 10, 2024

Copy link
Copy Markdown
Author

@NielsRogge can you please ping someone who can merge it?

@NielsRogge

Copy link
Copy Markdown
Contributor

Since this notebook is a copy of the object detection guide in Transformers (which already got an extensive review at huggingface/transformers#30683), I'll merge this one.

@NielsRogge

Copy link
Copy Markdown
Contributor

However @qubvel it's not in the right folder yet. We usually add them in the examples folder: https://github.com/huggingface/notebooks/tree/main/examples, although I feel like we should create subfolders there, however it breaks existing URLs.

@qubvel

qubvel commented May 10, 2024

Copy link
Copy Markdown
Author

Yeah, "open in colab" in the object-detection guide points to this notebook, I guess if we move it then it will be broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants