Skip to content

[LoRA] Add LoRA support to AuraFlow#10216

Merged
sayakpaul merged 70 commits into
huggingface:mainfrom
hameerabbasi:auraflow-lora
Apr 15, 2025
Merged

[LoRA] Add LoRA support to AuraFlow#10216
sayakpaul merged 70 commits into
huggingface:mainfrom
hameerabbasi:auraflow-lora

Conversation

@hameerabbasi

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is a simple rebase of #9017

cc @sayakpaul for review.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

Thanks for the helping hand, @hlky!

@hlky

hlky commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

See https://github.com/huggingface/diffusers/blob/main/tests/lora/test_lora_layers_flux.py https://github.com/huggingface/diffusers/blob/main/tests/lora/test_lora_layers_mochi.py etc as an example for tests. Seems to be missing transformer_cls, get_dummy_inputs and probably others, ping @sayakpaul if you need help with lora tests.

@hameerabbasi

hameerabbasi commented Dec 15, 2024

Copy link
Copy Markdown
Contributor Author

@sayakpaul Okay; I'm at a point where I've got actual, valid test failures but have no idea where to look.
pytest.log

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

Here's the log after the latest commit: pytest.log

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have left some comments to fix a couple of things. LMK if they're unclear.

Comment thread src/diffusers/loaders/lora_pipeline.py Outdated
Comment thread src/diffusers/loaders/lora_pipeline.py
Comment thread src/diffusers/loaders/lora_pipeline.py Outdated
Comment thread src/diffusers/loaders/lora_pipeline.py Outdated
Comment thread src/diffusers/loaders/lora_pipeline.py
Comment thread src/diffusers/loaders/lora_pipeline.py Outdated
@hameerabbasi

Copy link
Copy Markdown
Contributor Author

Latest test log.

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul Last CI ping. 😅

@sayakpaul

Copy link
Copy Markdown
Member

Code styling issues need to be fixed.

@sayakpaul

Copy link
Copy Markdown
Member

@bot /style

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Style fixes have been applied. View the workflow run here.

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul CI blocked again. 🥹

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul CI needs approval. 😅

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul CI ping. 🥹

@sayakpaul sayakpaul closed this Apr 10, 2025
@sayakpaul sayakpaul reopened this Apr 10, 2025
@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul Since I'm a first-time contributor, you'll need to approve the workflows on GitHub, opening/closing the PR or pushing commits doesn't seem to work. GitHub shows me the following notice on desktop, but the corresponding notice is invisible on mobile:
grafik

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul Another approval on CI please.

@hameerabbasi

Copy link
Copy Markdown
Contributor Author

@sayakpaul Merge before other issues pop up? 😛

@AstraliteHeart

Copy link
Copy Markdown
Contributor

@sayakpaul can we please get this merged? very excited about getting AF ecosystem up to speed.

@hameerabbasi

hameerabbasi commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

@sayakpaul The CI failures seem unrelated:

FAILED tests/pipelines/test_pipelines.py::DownloadTests::test_local_save_load_index - huggingface_hub.errors.LocalEntryNotFoundError

EDIT: This seems to be the cause:

Entry Not Found for url: https://huggingface.co/hf-internal-testing/tiny-playground-v2-5-pipe/resolve/f8baf778d35bdd9b187ae05f082700bc88e301a8/vae/diffusion_pytorch_model.bin.

@sayakpaul sayakpaul merged commit 9352a5c into huggingface:main Apr 15, 2025
@sayakpaul

Copy link
Copy Markdown
Member

Thanks for your contributions.

@hameerabbasi hameerabbasi deleted the auraflow-lora branch April 15, 2025 05:12
@hameerabbasi

Copy link
Copy Markdown
Contributor Author

Thanks so much for the reviews and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants