Fix test for converting tensor to proper dtype - #983
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
muellerzr
approved these changes
Jan 18, 2023
muellerzr
left a comment
Contributor
There was a problem hiding this comment.
Oopsie! Is it possible we could have written a test to catch this? Or not as much and it's just a silent-never-called bug
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a typo in #920 and forgot a
notwhile copy-pasting some code 😬This PR fixes that.