Skip to content

remove check for main process for trackers initialization#643

Merged
muellerzr merged 2 commits into
huggingface:mainfrom
Gladiator07:update-tracking-example
Aug 20, 2022
Merged

remove check for main process for trackers initialization#643
muellerzr merged 2 commits into
huggingface:mainfrom
Gladiator07:update-tracking-example

Conversation

@Gladiator07

@Gladiator07 Gladiator07 commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

Made the changes as discussed in this PR.

@muellerzr

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Aug 19, 2022

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@muellerzr

Copy link
Copy Markdown
Contributor

Thanks! Do you want to try to update the complete examples in this too? (The last spot would be in the docs, but I can update that :) )

@Gladiator07

Copy link
Copy Markdown
Contributor Author

Sure, I will update all the example scripts in the examples folder in this PR :)

@muellerzr

Copy link
Copy Markdown
Contributor

@Gladiator07 great! It should just be the complete_nlp_example and complete_cv_example

@Gladiator07

Copy link
Copy Markdown
Contributor Author

@muellerzr but many of the example scripts have the is_main_process check (for instance here). Should I update them as well or just complete_nlp_example and complete_cv_example ?

@muellerzr

Copy link
Copy Markdown
Contributor

Ah, great point! Yes in that case those would be great to have done as well! :)

@Gladiator07

Copy link
Copy Markdown
Contributor Author

Hi @muellerzr, I have removed the is_main_process check from all example scripts. Please check it once.

@muellerzr muellerzr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@muellerzr muellerzr merged commit 36420f5 into huggingface:main Aug 20, 2022
@Gladiator07 Gladiator07 deleted the update-tracking-example branch August 20, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants