[FSDP2] Shard eagerly initialized optimizer state - #4142
Draft
sdjasj wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves eagerly initialized optimizer state when FSDP2 replaces full model parameters with sharded DTensors.
Adagrad initializes
stepandsumstate in its constructor. FSDP2 preparation previously replaced only optimizerparam_groups, so the state remained keyed by the original parameters. Moving the key alone is insufficient because parameter-shaped state must also use the new parameter's DTensor mesh, placements, and local device.This change moves state keys through the temporary parameter placeholders, rekeys them to the final FSDP2 parameters, and distributes parameter-shaped state tensors with the same layout and device. Scalar state remains unchanged. A multi-process regression test exercises an Adagrad forward/backward/step and optimizer serialization.
Fixes #3859
Validation