Deinitialization with dev as base#67
Merged
Johannes-Schneider merged 1 commit intodevfrom Feb 15, 2018
Merged
Conversation
justus-hildebrand
approved these changes
Feb 12, 2018
Collaborator
justus-hildebrand
left a comment
There was a problem hiding this comment.
LGTM. When merging this, remember to open a new issue for the OpenSSL deinitialization.
|
|
||
| deinitialize::_DeinitV8(); | ||
|
|
||
| // TODO(js): Do we need to tear down OpenSsl? |
Collaborator
There was a problem hiding this comment.
I am by no means an expert on OpenSSL, but according to their wiki, there are some cleanup mechanisms we should look into.
Unfortunately I don't know how node uses OpenSSL, so I have no idea which parts of the cleanup from the wiki would be necessary, but I think we should investigate this to avoid any memory leaks we can (we will have to live with some introduced by OpenSSL).
Feel free to place this into a new issue, as I think it'd break the size of the issue this PR is dealing with.
luminosuslight
approved these changes
Feb 12, 2018
msoechting
pushed a commit
that referenced
this pull request
Feb 21, 2018
Deinitialization with dev as base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code from initial PR (#62)